Fix deleting files within 60sec interval #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sruti Parthiban <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
============================================
- Coverage 72.18% 72.15% -0.03%
Complexity 356 356
============================================
Files 44 44
Lines 2509 2510 +1
Branches 160 160
============================================
Hits 1811 1811
- Misses 592 593 +1
Partials 106 106
Continue to review full report at Codecov.
|
kjoseph07
approved these changes
Sep 3, 2021
Member
|
This kind of bugs definitely needs tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sruti Parthiban [email protected]
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#61
Writer metrics are filling up the disk. Currently, the cleanup method deletes the writer files (https://github.com/opensearch-project/performance-analyzer/blob/main/src/main/java/org/opensearch/performanceanalyzer/writer/EventLogQueueProcessor.java#L190)
This method deletes files up to the current time, but the file creation happens after this. Thus one file is left out during the file deletion. This cause accumulation of writer files.
Describe the solution you are proposing
Delete writer files only when they are older than 60sec.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.