Fix build to succeed with opensearch_version provided #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mch2
force-pushed
the
fixVersionFlag
branch
2 times, most recently
from
ed07f22 to
cd5077c
Compare
Codecov Report
@@ Coverage Diff @@
## main #52 +/- ##
=========================================
Coverage 72.18% 72.18%
Complexity 356 356
=========================================
Files 44 44
Lines 2509 2509
Branches 160 160
=========================================
Hits 1811 1811
Misses 592 592
Partials 106 106 Continue to review full report at Codecov.
|
Signed-off-by: Marc Handalian <[email protected]>
1 task
dblock
approved these changes
Aug 20, 2021
sruti1312
approved these changes
Aug 20, 2021
sruti1312
pushed a commit
that referenced
this pull request
Aug 25, 2021
Signed-off-by: Marc Handalian <[email protected]>
sruti1312
added a commit
that referenced
this pull request
Aug 25, 2021
* Create writer file if metrics are available (#31) Signed-off-by: Sruti Parthiban <[email protected]> * Add tests to check for writer file only if metrics are present (#35) Signed-off-by: Sruti Parthiban <[email protected]> * Merge pull request #36 from opensearch-project/khushbr-writer-purge-fix Fixing Event Log file cleanup issue * Moving deleteAllFiles() to inside scheduleExecutor() * Fixing the Link Checker errors, updating the official documentation * nit: Fixing spotlessJava indentation issue * Merge pull request #37 from khushbr/feature/purge-fix Handling purging of lingering files before scheduleExecutor start. * Fix failing file handler test (#38) Signed-off-by: Sruti Parthiban <[email protected]> * Remove dependency on main branch when running spotless. (#47) Signed-off-by: Marc Handalian <[email protected]> * Updates to gradle build file (#48) * Updates to gradle build file Signed-off-by: Sruti Parthiban <[email protected]> * Add ability to specify RCA branch Signed-off-by: Sruti Parthiban <[email protected]> * Fix build when opensearch_version flag is provided. (#52) Signed-off-by: Marc Handalian <[email protected]> * Update the version to 1.0.1 Signed-off-by: Sruti Parthiban <[email protected]> Co-authored-by: Khushboo Rajput <[email protected]> Co-authored-by: Khushboo Rajput <[email protected]> Co-authored-by: Marc Handalian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marc Handalian [email protected]
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
The build is failing when opensearch version specified is not the same as the default value.
Describe the solution you are proposing
The cause of this problem is updateShas is invoked, which is a task in this project, during the doLast step of the buildRCA task. This task is not invoked with any properties passed in during the initial build command.
This change will execute this directly with finalizedBy instead of using doLast and executing from the command line.
Describe alternatives you've considered
passing the version string down to doLast. I would rather directly invoke the task without executing from shell.
closes #51
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.