Skip to content

Conversation

@sgup432
Copy link
Contributor

@sgup432 sgup432 commented Mar 11, 2022

Signed-off-by: Sagar Upadhyaya [email protected]

Is your feature request related to a problem? Please provide an existing Issue # , or describe.

  1. Adding CI matrix for JDK 8, 11 and 14 in CI workflow
  2. Updating developer guide to use JDK 11

Solves: opensearch-project/performance-analyzer#91

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sagar Upadhyaya <[email protected]>
@sgup432 sgup432 requested review from a team, dzane17, kkhatua and sruti1312 March 11, 2022 20:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #145 (26c9c53) into main (8214254) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #145      +/-   ##
============================================
+ Coverage     71.91%   72.07%   +0.15%     
- Complexity     2943     2963      +20     
============================================
  Files           376      376              
  Lines         18774    18834      +60     
  Branches       1437     1465      +28     
============================================
+ Hits          13501    13574      +73     
+ Misses         4686     4677       -9     
+ Partials        587      583       -4     
Impacted Files Coverage Δ
...manceanalyzer/rca/persistence/SQLitePersistor.java 76.22% <0.00%> (+0.92%) ⬆️
...nsearch/performanceanalyzer/rca/RcaController.java 80.61% <0.00%> (+1.32%) ⬆️
.../opensearch/performanceanalyzer/jvm/GCMetrics.java 57.35% <0.00%> (+1.47%) ⬆️
...ceanalyzer/reader/MasterMetricsEventProcessor.java 90.74% <0.00%> (+1.85%) ⬆️
...anceanalyzer/reader/AdmissionControlProcessor.java 74.41% <0.00%> (+2.32%) ⬆️
...formanceanalyzer/PerformanceAnalyzerWebServer.java 74.62% <0.00%> (+5.97%) ⬆️
...nalyzer/rca/net/handler/PublishRequestHandler.java 88.00% <0.00%> (+14.00%) ⬆️
...pensearch/performanceanalyzer/jvm/HeapMetrics.java 56.25% <0.00%> (+15.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8214254...26c9c53. Read the comment docs.

@sruti1312 sruti1312 merged commit 4e7ed7a into opensearch-project:main Mar 14, 2022
sruti1312 pushed a commit that referenced this pull request Mar 15, 2022
* Add CI matrix for jdk 8, 11 and 14

Signed-off-by: Sagar Upadhyaya <[email protected]>

* Adding check to not add javadoc options for jdk 8

Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: sruti1312 <[email protected]>
sruti1312 added a commit that referenced this pull request Mar 15, 2022
* Adding check to avoid adding module export for jdk8 (#146)

Signed-off-by: Sagar Upadhyaya <[email protected]>

* Add CI matrix for jdk 8, 11 and 14 (#145)

* Add CI matrix for jdk 8, 11 and 14

Signed-off-by: Sagar Upadhyaya <[email protected]>

* Adding check to not add javadoc options for jdk 8

Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: sruti1312 <[email protected]>

Co-authored-by: Sagar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants