Removing deprecated InitialBootClassLoaderMetaspaceSize JVM command line flag #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine flag Signed-off-by: Andriy Redko <[email protected]>
saratvemulapalli
approved these changes
Jan 20, 2022
Contributor
Author
|
@qreshi fyi |
|
Relating issue #117 here as well as it is the issue that was opened for this repo specifically |
kjoseph07
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko [email protected]
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
The
InitialBootClassLoaderMetaspaceSizeJVM command line flag has been deprecated in JDK-15 [1] and removed in JDK-16 [2].[1] https://bugs.openjdk.java.net/browse/JDK-8242426
[2] https://bugs.openjdk.java.net/browse/JDK-8221173
Related to opensearch-project/opensearch-build#1523
Describe the solution you are proposing
Drop
InitialBootClassLoaderMetaspaceSizeusageDescribe alternatives you've considered
Make the command line logic dependent on JVM version being used
Additional context
Closes #117
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.