Skip to content

Conversation

@Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Oct 3, 2022

Description

Updates the quote & syn dependencies to 1.x

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia requested a review from a team as a code owner October 3, 2022 01:57
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Merging #80 (a6e43f1) into main (a6e43f1) will not change coverage.
The diff coverage is n/a.

❗ Current head a6e43f1 differs from pull request most recent head ca87836. Consider uploading reports for the commit ca87836 to get more accurate results

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   42.09%   42.09%           
=======================================
  Files          49       49           
  Lines       28666    28666           
=======================================
  Hits        12067    12067           
  Misses      16599    16599           
Flag Coverage Δ
integration 42.09% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

};
use base64::write::EncoderWriter as Base64Encoder;
use bytes::BytesMut;
use dyn_clone::clone_trait_object;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's used at line 493:

pub trait ConnectionPool: Debug + dyn_clone::DynClone + Sync + Send {
/// Gets a reference to the next [Connection]
fn next(&self) -> &Connection;
}
clone_trait_object!(ConnectionPool);

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xtansia Xtansia requested a review from dblock October 10, 2022 20:51
@VachaShah
Copy link
Collaborator

@dblock Review please?

@dblock dblock merged commit 9c02e37 into opensearch-project:main Nov 9, 2022
@Xtansia Xtansia deleted the fix/update-quote branch March 10, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants