-
Notifications
You must be signed in to change notification settings - Fork 35
Update quote & syn dependencies to 1.x #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 42.09% 42.09%
=======================================
Files 49 49
Lines 28666 28666
=======================================
Hits 12067 12067
Misses 16599 16599
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| }; | ||
| use base64::write::EncoderWriter as Base64Encoder; | ||
| use bytes::BytesMut; | ||
| use dyn_clone::clone_trait_object; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's used at line 493:
opensearch-rs/opensearch/src/http/transport.rs
Lines 488 to 493 in 35da373
| pub trait ConnectionPool: Debug + dyn_clone::DynClone + Sync + Send { | |
| /// Gets a reference to the next [Connection] | |
| fn next(&self) -> &Connection; | |
| } | |
| clone_trait_object!(ConnectionPool); |
VachaShah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
35da373 to
ca87836
Compare
|
@dblock Review please? |
Description
Updates the quote & syn dependencies to 1.x
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.