Add bulk guide #155
Merged
Add bulk guide #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sabina.zaripova <[email protected]>
sayuree
requested review from
VachaShah,
Xtansia,
dblock and
reta
as code owners
Signed-off-by: sabina.zaripova <[email protected]>
Xtansia
added
documentation
Xtansia
requested changes
Apr 24, 2023
Collaborator
Xtansia
left a comment
Xtansia
left a comment
There was a problem hiding this comment.
Hey @sayuree, thanks for contributing!
Overall the guide looks good, just some minor code issues.
It would also be great if you could create a matching example file like this one: https://github.com/opensearch-project/opensearch-rs/blob/main/opensearch/examples/index_template.rs
It's very useful for making sure the code is correct and compiles.
Signed-off-by: sabina.zaripova <[email protected]>
reta
reviewed
May 5, 2023
reta
reviewed
May 5, 2023
Signed-off-by: sabina.zaripova <[email protected]>
Xtansia
requested changes
May 15, 2023
Signed-off-by: sabina.zaripova <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 65.43% 73.62% +8.19%
==========================================
Files 315 398 +83
Lines 52415 62810 +10395
==========================================
+ Hits 34296 46246 +11950
+ Misses 18119 16564 -1555
Flags with carried forward coverage won't be shown. Click here to find out more. |
Xtansia
reviewed
May 21, 2023
Signed-off-by: sabina.zaripova <[email protected]>
Xtansia
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Bulk guide
Issues Resolved
closes #144
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.