Skip to content

Conversation

@gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Apr 19, 2023

Depend PRs to be merged before this goes in opensearch-project/opensearch-build-libraries#194
Feel free to review till then.

Description

Add release workflow for publishing opensearch-rs client to crates.io
Also adds 2PR approval in the release drafter that would need codeowners to approve the release. Currently set the approval to 2. Sample issue that will be created: gaiksaya#2

Issues Resolved

resolves opensearch-project/opensearch-build#3247

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #153 (08e844a) into main (c28431f) will increase coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   65.50%   65.54%   +0.04%     
==========================================
  Files         316      316              
  Lines       52547    52547              
==========================================
+ Hits        34419    34442      +23     
+ Misses      18128    18105      -23     
Flag Coverage Δ
integration 65.54% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this?

@gaiksaya
Copy link
Member Author

Let's merge this?

Waiting for dependent PR to merge :/

@gaiksaya gaiksaya marked this pull request as ready for review April 25, 2023 19:47
@gaiksaya gaiksaya requested review from VachaShah and reta as code owners April 25, 2023 19:47
@gaiksaya gaiksaya merged commit 2e9033a into opensearch-project:main Apr 25, 2023
@gaiksaya gaiksaya deleted the add-release-workflows branch April 25, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[release]: One-click release for opensearch-rs

4 participants