-
Notifications
You must be signed in to change notification settings - Fork 35
[CCI] Create advanced index actions guide #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCI] Create advanced index actions guide #147
Conversation
Signed-off-by: Alexei Karikov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your guide is still referencing and using Ruby, it has not been updated to Rust.
I think it would be beneficial for you to create an accompanying opensearch/examples/advanced_index_actions.rs example file that combines all the snippets together to ensure the code is valid, compiles and can be run successfully.
Signed-off-by: Alexei Karikov <[email protected]>
Signed-off-by: Alexei Karikov <[email protected]>
I think we already are discussing how to run these samples in CI, separate issue but thought I'd mention it. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 65.07% 65.38% +0.31%
==========================================
Files 312 314 +2
Lines 51715 52182 +467
==========================================
+ Hits 33652 34119 +467
Misses 18063 18063
Flags with carried forward coverage won't be shown. Click here to find out more. see 34 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Alexei Karikov <[email protected]>
|
dblock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Link checker needs to pass.
Consider linking to the documentation concepts like "force merge" when they are mentioned.
| @@ -0,0 +1,113 @@ | |||
| # Advanced Index Actions | |||
|
|
|||
| In this guide, we will look at some advanced index actions that are not covered in the [Index Lifecycle](index_lifecycle.md) guide. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file doesn't exist yet, so the link checker breaks. You can combine all the guides in 1 PR or make them in order they link to each-other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dblock Can we wait for the index lifecycle to merge first and then re-run the link checker?
Signed-off-by: Alexei Karikov <[email protected]>
Signed-off-by: Alexei Karikov <[email protected]>
Signed-off-by: Alexei Karikov <[email protected]>
Signed-off-by: Alexei Karikov <[email protected]>
Signed-off-by: Alexei Karikov <[email protected]>
Description
Using the doc: Opensearch rust
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.