-
Notifications
You must be signed in to change notification settings - Fork 124
Add phase_took feature to Search API #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add phase_took feature to Search API #722
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
==========================================
+ Coverage 57.29% 60.33% +3.04%
==========================================
Files 315 377 +62
Lines 9823 11698 +1875
==========================================
+ Hits 5628 7058 +1430
- Misses 2902 3205 +303
- Partials 1293 1435 +142
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
52848f3 to
2ca3339
Compare
Jakob3xD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems, this options was added in 2.12.x. Please add the SkipIfBelowVersion function of our internal test package to skip the test if the version does not support it.
Thank you.
2ca3339 to
e247ebf
Compare
Signed-off-by: ForeverSRC <[email protected]>
Signed-off-by: ForeverSRC <[email protected]>
e247ebf to
08440a9
Compare
Signed-off-by: ForeverSRC <[email protected]>
@Jakob3xD Thank you. I have added the SkipIfBelowVersion`. |
Description
The change is to add the
phase_tookfeature in Search API start from OpenSearch 2.12Example
Reference:
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.