Make polyholes() act a little more like cylinder() #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperair
reviewed
Jan 6, 2020
| n = max(round(2 * d),3); | ||
| module polyhole(h, d=0, r=0, center=false) { | ||
| _r = (r == 0 ? d / 2 : r); | ||
| _d = (d == 0 ? r * 2 : d); |
There was a problem hiding this comment.
I think you mean to use _r in this line, otherwise it won't be used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nophead 's
polyholefunction could use a little more love and attention to make it act a little more likecylinder.This PR adds the
centerandrparameters, defaulting them to existing behavior if they aren't specified.