Add Transient annotation to Collections without JPA annotations #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evie-lau
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/migrate/javax/AddTransientAnnotation.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/javax/AddTransientAnnotationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/javax/AddTransientAnnotationTest.java
Outdated
Show resolved
Hide resolved
|
Marking as draft as I realized I may need to modify the recipe criteria from "unannotated Collections" to "Collections without JPA annotations" |
evie-lau
commented
Feb 20, 2024
src/main/java/org/openrewrite/java/migrate/javax/AddTransientAnnotationToCollections.java
Outdated
Show resolved
Hide resolved
evie-lau
changed the title
cjobinabo
reviewed
Mar 8, 2024
src/main/java/org/openrewrite/java/migrate/javax/AddTransientAnnotationToCollections.java
Outdated
Show resolved
Hide resolved
cjobinabo
reviewed
Mar 8, 2024
src/test/java/org/openrewrite/java/migrate/javax/AddTransientAnnotationToCollectionsTest.java
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
src/main/java/org/openrewrite/java/migrate/javax/AddTransientAnnotationToCollections.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/javax/AddTransientAnnotationToCollectionsTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
langchain4j
pushed a commit
to langchain4j/langchain4j
that referenced
this pull request
Oct 11, 2024
As discussed on #622 (review), this PR adds a workflow to automatically review pull requests. The rules are configurable and can be extended; I'd thought to start small, and then expand in separate pull requests where I both make the changes to the project, and add the recipe to the list of suggestions for future pull requests. As an example of what this looks like in practice, have a look at openrewrite/rewrite-migrate-java#421 Notice how we have a bot `github-actions` that places code suggestion comments that can be quickly applied by the user. This should make for a reasonably friction-free enforcement of code standards going forward, using mostly standard components + https://github.com/googleapis/code-suggester  I'll self review with a few small callouts below, just to make review easier. Assumes that we first merge my other pull request, such that we don't get any suggestions for items fixed there. - #622
jinsihou19
pushed a commit
to jinsihou19/langchain4j
that referenced
this pull request
May 12, 2025
As discussed on langchain4j#622 (review), this PR adds a workflow to automatically review pull requests. The rules are configurable and can be extended; I'd thought to start small, and then expand in separate pull requests where I both make the changes to the project, and add the recipe to the list of suggestions for future pull requests. As an example of what this looks like in practice, have a look at openrewrite/rewrite-migrate-java#421 Notice how we have a bot `github-actions` that places code suggestion comments that can be quickly applied by the user. This should make for a reasonably friction-free enforcement of code standards going forward, using mostly standard components + https://github.com/googleapis/code-suggester  I'll self review with a few small callouts below, just to make review easier. Assumes that we first merge my other pull request, such that we don't get any suggestions for items fixed there. - langchain4j#622
AImaniadev
added a commit
to AImaniadev/langchain4j-Java-LLMs
that referenced
this pull request
Jul 10, 2025
As discussed on langchain4j/langchain4j#622 (review), this PR adds a workflow to automatically review pull requests. The rules are configurable and can be extended; I'd thought to start small, and then expand in separate pull requests where I both make the changes to the project, and add the recipe to the list of suggestions for future pull requests. As an example of what this looks like in practice, have a look at openrewrite/rewrite-migrate-java#421 Notice how we have a bot `github-actions` that places code suggestion comments that can be quickly applied by the user. This should make for a reasonably friction-free enforcement of code standards going forward, using mostly standard components + https://github.com/googleapis/code-suggester  I'll self review with a few small callouts below, just to make review easier. Assumes that we first merge my other pull request, such that we don't get any suggestions for items fixed there. - #622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
OpenJPA -> EclipseLink migration recipe
Add
@Transientannotation to Collections without JPA annotations to keep the OpenJPA behavior of ignoring unannotated Collections in EclipseLinkWhat's your motivation?
https://wiki.eclipse.org/EclipseLink/Examples/JPA/Migration/OpenJPA/Mappings#Unannotated_Collection_Fields
Checklist