Maven multi modules resources not handled correctly #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timtebeek
commented
Oct 27, 2025
timtebeek
commented
- Fixes Hierarchical multi-module Maven projects exclude all child module resources #1066
shanman190
approved these changes
Oct 27, 2025
Contributor
shanman190
left a comment
shanman190
left a comment
There was a problem hiding this comment.
Looks good to me. Just the one comment related to keeping the tests passing on Windows as best as possible.
Co-authored-by: Shannon Pamperl <[email protected]>
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Nov 10, 2025
…2.1 to 6.23.0 [skip ci] [//]: # (dependabot-start)⚠️ \*\*Dependabot is rebasing this PR\*\*⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [org.openrewrite.maven:rewrite-maven-plugin](https://github.com/openrewrite/rewrite-maven-plugin) from 6.22.1 to 6.23.0. Release notes *Sourced from [org.openrewrite.maven:rewrite-maven-plugin's releases](https://github.com/openrewrite/rewrite-maven-plugin/releases).* > 6.23.0 > ------ > > What's Changed > -------------- > > * Avoid duplicate Java sources by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1060](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1060) > * chore(ci): bump org.openrewrite:rewrite-bom from 8.65.0-SNAPSHOT to 8.65.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1061](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1061) > * chore(ci): bump actions/upload-artifact from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1062](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1062) > * chore(ci): bump actions/download-artifact from 5 to 6 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1063](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1063) > * chore(ci): bump org.openrewrite:rewrite-polyglot from 2.7.3 to 2.7.4 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1064](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1064) > * chore(ci): bump maven-plugin-tools.version from 3.15.1 to 3.15.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1065](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1065) > * Maven multi modules resources not handled correctly by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1067](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1067) > * Update SDKMan Java version by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1068](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1068) > * Bump rewrite-polyglot versions before and after release by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1069](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1069) > * chore(ci): bump org.junit:junit-bom from 5.13.4 to 6.0.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1048](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1048) > * chore(ci): bump org.junit:junit-bom from 6.0.0 to 6.0.1 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1070](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1070) > > **Full Changelog**: <openrewrite/rewrite-maven-plugin@v6.22.1...v6.23.0> Commits * [`f4776de`](openrewrite/rewrite-maven-plugin@f4776de) [maven-release-plugin] prepare release v6.23.0 * [`d366884`](openrewrite/rewrite-maven-plugin@d366884) Bump rewrite.version property * [`a81d991`](openrewrite/rewrite-maven-plugin@a81d991) chore(ci): bump org.junit:junit-bom from 6.0.0 to 6.0.1 ([#1070](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1070)) * [`cefdb76`](openrewrite/rewrite-maven-plugin@cefdb76) chore(ci): bump org.junit:junit-bom from 5.13.4 to 6.0.0 ([#1048](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1048)) * [`d4287bd`](openrewrite/rewrite-maven-plugin@d4287bd) Bump rewrite-polyglot versions before and after release ([#1069](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1069)) * [`f9d5442`](openrewrite/rewrite-maven-plugin@f9d5442) Bump rewrite.version property * [`15199c2`](openrewrite/rewrite-maven-plugin@15199c2) Update SDKMan Java version ([#1068](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1068)) * [`451f3ba`](openrewrite/rewrite-maven-plugin@451f3ba) Maven multi modules resources not handled correctly ([#1067](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1067)) * [`af2655c`](openrewrite/rewrite-maven-plugin@af2655c) chore(ci): bump maven-plugin-tools.version from 3.15.1 to 3.15.2 ([#1065](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1065)) * [`d43957a`](openrewrite/rewrite-maven-plugin@d43957a) chore(ci): bump org.openrewrite:rewrite-polyglot from 2.7.3 to 2.7.4 ([#1064](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1064)) * Additional commits viewable in [compare view](openrewrite/rewrite-maven-plugin@v6.22.1...v6.23.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.