Skip to content

(fix) Fix overlay stacking context so Datepicker isn't hidden on tablet#96

Merged
denniskigen merged 1 commit into
mainfrom
feat/datepicker
Oct 24, 2023
Merged

(fix) Fix overlay stacking context so Datepicker isn't hidden on tablet#96
denniskigen merged 1 commit into
mainfrom
feat/datepicker

Conversation

@donaldkibet

@donaldkibet donaldkibet commented Oct 24, 2023

Copy link
Copy Markdown
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes a display issue with the DatePicker on tablet devices due to a higher z-index value on its parent container. Additionally, it removes the scrollbar to enhance the user experience by preventing flickering. Below GIF shows the fix and the error

Screenshots

Kapture 2023-10-24 at 20 07 55

Related Issue

Other

@denniskigen denniskigen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround, @donaldkibet.

It appears scrollbar-width is only compatible with Firefox whereas -ms-overflow-style is non-standard.

You might need to add something like:

  ::-webkit-scrollbar {
    display: none;
    width: 0;
    height: 0;
  }

To get the same results in Webkit browsers (Chrome, Safari, Edge).

@ibacher

ibacher commented Oct 24, 2023

Copy link
Copy Markdown
Member

Or, better yet, we could start leveraging postcss for stuff like this. With this plugin.

@denniskigen denniskigen changed the title (fix) Update z-index to show Date picker and hide scroll bars (fix) Fix overlay stacking context so Datepicker isn't hidden on tablet Oct 24, 2023
@denniskigen

Copy link
Copy Markdown
Member

LGTM

@denniskigen denniskigen merged commit f46dfc1 into main Oct 24, 2023
@denniskigen denniskigen deleted the feat/datepicker branch October 24, 2023 20:35
@denniskigen

denniskigen commented Oct 24, 2023

Copy link
Copy Markdown
Member

@donaldkibet thanks for decoupling the scrolling issue and the z-index concern. It'd be nice to address the scrolling issue in a separate PR. Do you need a version bump in Patient Chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants