(fix) Fix overlay stacking context so Datepicker isn't hidden on tablet#96
Merged
Conversation
CynthiaKamau
approved these changes
Oct 24, 2023
denniskigen
reviewed
Oct 24, 2023
Member
There was a problem hiding this comment.
Thanks for the quick turnaround, @donaldkibet.
It appears scrollbar-width is only compatible with Firefox whereas -ms-overflow-style is non-standard.
You might need to add something like:
::-webkit-scrollbar {
display: none;
width: 0;
height: 0;
}To get the same results in Webkit browsers (Chrome, Safari, Edge).
Member
|
Or, better yet, we could start leveraging postcss for stuff like this. With this plugin. |
136933f to
55316e5
Compare
denniskigen
approved these changes
Oct 24, 2023
Member
|
LGTM |
Member
|
@donaldkibet thanks for decoupling the scrolling issue and the z-index concern. It'd be nice to address the scrolling issue in a separate PR. Do you need a version bump in Patient Chart? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes a display issue with the DatePicker on tablet devices due to a higher z-index value on its parent container. Additionally, it removes the scrollbar to enhance the user experience by preventing flickering. Below GIF shows the fix and the error
Screenshots
Related Issue
Other