(fix) O3-2313: Duplicate Diagnoses in Submitted JSON Form#63
Merged
Conversation
AlexanderMizgirev
force-pushed
the
O3-2313
branch
from
54ba1c6 to
c49cb86
Compare
ibacher
approved these changes
Aug 28, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This pull request fixes the bug that caused duplicate diagnoses. The bug, as I understand it, was due to the fact that recursion was used in the function to traverse the nodes, and the function didn't check whether a node had been processed or not. Now, with the addition of this check, such situations should be eliminated.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-2313
Other