(feat) KHP3-3708 Add adapter in form engine to handle creating patient identifiers#55
Merged
Conversation
CynthiaKamau
approved these changes
Jul 3, 2023
denniskigen
reviewed
Jul 3, 2023
| import { ControlRelationsFactory } from '../form-factory/control-relations.factory'; | ||
| import { NodeBase } from '../form-factory/form-node'; | ||
| import { DebugModeService } from './../services/debug-mode.service'; | ||
| import { PatientIdenfierAdapater } from './patient-identifier.adapter'; |
Member
There was a problem hiding this comment.
There's a typo in this file name as well as in this import.
3 tasks
denniskigen
reviewed
Jul 3, 2023
|
|
||
| const adultForm = require('../../adult.json'); | ||
| const mockLocationUuid = "some-location-uuid"; | ||
| fdescribe('Patient identifier Value Adapter:', () => { |
Member
There was a problem hiding this comment.
We shouldn't need this fdescribe as there's only this one suite in this file.
denniskigen
reviewed
Jul 3, 2023
| const mockLocationUuid = "some-location-uuid"; | ||
| fdescribe('Patient identifier Value Adapter:', () => { | ||
| let adultFormSchema: any; | ||
| beforeEach(() => { |
Member
There was a problem hiding this comment.
The indentation is off for this file. The tab size ought to be 2 instead of 4.
denniskigen
reviewed
Jul 3, 2023
| import { Injectable } from "@angular/core"; | ||
|
|
||
| import { NodeBase, GroupNode, ArrayNode } from "../form-factory/form-node"; | ||
| import { Form } from "../form-factory"; |
Member
There was a problem hiding this comment.
This file ought to use a tab size of 2 as well.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds ability to generate patient identifiers. In addition it also adds ability to populate fields with type
patientIdentiferwith existing identifiers.Screenshots
Related Issue
https://thepalladiumgroup.atlassian.net/browse/KHP3-3708
Other