Skip to content

(feat) Remove some cruft and unused dependencies#113

Merged
ibacher merged 1 commit into
mainfrom
feat/remove-cruft
Jan 5, 2024
Merged

(feat) Remove some cruft and unused dependencies#113
ibacher merged 1 commit into
mainfrom
feat/remove-cruft

Conversation

@denniskigen

@denniskigen denniskigen commented Jan 5, 2024

Copy link
Copy Markdown
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR removes unused code and dependencies from the Form Entry library, including:

  • Removing a custom proxy config only relevant in the AMPATH ecosystem
  • Removing the slick-carousel package and related code
  • Deleting an unused build script
  • Removing the unused @material/mwc-switch dependency
  • Replacing the default Angular favicon with OpenMRS favicon sprite
  • Deleting the SystemJS script import in index.html
  • Updating lib and module tsconfig targets to ES2022 in the tsconfig.json file

I've tested that the library works in the patient chart clinical forms workspace (see the screenshot below).

Screenshots

Working clinical form

CleanShot 2024-01-05 at 10  21 22@2x

Related Issue

None

Other

None

@denniskigen denniskigen changed the title (feat) Remove some cruft (feat) Remove some cruft and unused dependencies Jan 5, 2024
@ibacher

ibacher commented Jan 5, 2024

Copy link
Copy Markdown
Member

Thanks @denniskigen! This kind of clean-up is great to see!

@ibacher ibacher merged commit f9c6d47 into main Jan 5, 2024
@denniskigen denniskigen deleted the feat/remove-cruft branch January 5, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants