[ISSUE#173] fix DLedgerServer The code is not formatted correctly #174
Conversation
| public DLedgerStore getdLedgerStore() { | ||
| public DLedgerStore getDLedgerStore() { | ||
| return dLedgerStore; | ||
| } | ||
|
|
||
| public DLedgerRpcService getdLedgerRpcService() { | ||
| public DLedgerRpcService getDLedgerRpcService() { | ||
| return dLedgerRpcService; | ||
| } | ||
|
|
||
| public DLedgerLeaderElector getdLedgerLeaderElector() { | ||
| public DLedgerLeaderElector getDLedgerLeaderElector() { | ||
| return dLedgerLeaderElector; | ||
| } | ||
|
|
||
| public DLedgerConfig getdLedgerConfig() { | ||
| public DLedgerConfig getDLedgerConfig() { | ||
| return dLedgerConfig; | ||
| } |
There was a problem hiding this comment.
Directly modifying these interface names will cause compatibility problems
There was a problem hiding this comment.
add @deprecated annotation for those methods instead of Directly modifying these interface names. and add a new method like getDLedgerConfig to solution compatibility problems.
There was a problem hiding this comment.
Directly modifying these interface names will cause compatibility problems
I search found that RocketMQ uses these methods, and it does cause compatibility issues if you change them directly.add @deprecated annotation for those methods instead of Directly modifying these interface names. and add a new method like getDLedgerConfig to solution compatibility problems.
There was a problem hiding this comment.
Directly modifying these interface names will cause compatibility problems
I search found that RocketMQ uses these methods, and it does cause compatibility issues if you change them directly.add @deprecated annotation for those methods instead of Directly modifying these interface names. and add a new method like getDLedgerConfig to solution compatibility problems.
Good idea！
There was a problem hiding this comment.
Directly modifying these interface names will cause compatibility problems
I search found that RocketMQ uses these methods, and it does cause compatibility issues if you change them directly.add @deprecated annotation for those methods instead of Directly modifying these interface names. and add a new method like getDLedgerConfig to solution compatibility problems.
Good idea！
I solved the compatibility problem and The code was resubmitted
Fix(173) DLedgerServer The code is not formatted correctly and Correct incorrect words in comment lines