Skip to content

[Bug] NPE when enable batch push #134

@cserwen

Description

@cserwen

Question

  • When set enableBatchPush as true,It will occasionally has NPE bugs when elections occur.
2022-04-27 18:58:41 ERROR NettyServerPublicExecutor_1 - process request exception 
java.lang.NullPointerException: null 
       at io.openmessaging.storage.dledger.DLedgerEntryPusher$EntryHandler.buildResponse(DLedgerEntryPusher.java:808) 
       at io.openmessaging.storage.dledger.DLedgerEntryPusher$EntryHandler.handlePush(DLedgerEntryPusher.java:781) 
       at io.openmessaging.storage.dledger.DLedgerEntryPusher.handlePush(DLedgerEntryPusher.java:100) 
       at io.openmessaging.storage.dledger.DLedgerServer.handlePush(DLedgerServer.java:268) 
       at io.openmessaging.storage.dledger.DLedgerRpcNettyService.handlePush(DLedgerRpcNettyService.java:442) 
       at io.openmessaging.storage.dledger.DLedgerRpcNettyService.processRequest(DLedgerRpcNettyService.java:363) 
       at io.openmessaging.storage.dledger.DLedgerRpcNettyService$4.processRequest(DLedgerRpcNettyService.java:104) 
       at org.apache.rocketmq.remoting.netty.NettyRemotingAbstract$1.run(NettyRemotingAbstract.java:234) 
       at org.apache.rocketmq.remoting.netty.RequestTask.run(RequestTask.java:80) 
       at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
       at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
       at java.lang.Thread.run(Thread.java:748) 
2022-04-27 18:58:41 ERROR NettyServerPublicExecutor_1 - RemotingCommand [code=51004, language=JAVA, version=373, opaque=1357831504, flag(B)=0, remark=null, extFields=null, serializeTypeCurrentRPC=JSON]

How to fix ?

future.complete(buildResponse(request, DLedgerResponseCode.REPEATED_PUSH.getCode()));

image

In this case, batch is not processed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions