Skip to content

Conversation

aiyijing
Copy link

@aiyijing aiyijing commented Jun 27, 2025

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to master. They are not published on branches.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrisliu1995 for approval by writing /assign @chrisliu1995 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @aiyijing! It looks like this is your first PR to openkruise/charts 🎉

@aiyijing
Copy link
Author

Hi there!

The label control-plane: controller-manager is the default from Kubebuilder scaffolding, but it's too generic.
In environments with multiple custom controllers, this label may unintentionally match unrelated Pods or Services, leading to incorrect selection or monitoring.

This PR updates it to control-plane: kruise-controller-manager to make it specific to Kruise and avoid such conflicts.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants