Skip to content

8364723: Sort share/interpreter includes #26639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fandreuz
Copy link
Contributor

@fandreuz fandreuz commented Aug 5, 2025

This PR sorts the includes in hotspot/share/interpreter using SortIncludes.java. I'm also adding the directory to TestIncludesAreSorted.

Passes tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8364723: Sort share/interpreter includes (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26639/head:pull/26639
$ git checkout pull/26639

Update a local copy of the PR:
$ git checkout pull/26639
$ git pull https://git.openjdk.org/jdk.git pull/26639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26639

View PR using the GUI difftool:
$ git pr show -t 26639

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26639.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2025

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 5, 2025

@fandreuz This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 5, 2025
@openjdk
Copy link

openjdk bot commented Aug 5, 2025

@fandreuz The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Aug 5, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

/reviewers 2

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 5, 2025
@openjdk
Copy link

openjdk bot commented Aug 5, 2025

@shipilev
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants