-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8364723: Sort share/interpreter includes #26639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into |
@fandreuz This change is no longer ready for integration - check the PR body for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine.
/reviewers 2
This PR sorts the includes in
hotspot/share/interpreter
using SortIncludes.java. I'm also adding the directory to TestIncludesAreSorted.Passes tier1.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26639/head:pull/26639
$ git checkout pull/26639
Update a local copy of the PR:
$ git checkout pull/26639
$ git pull https://git.openjdk.org/jdk.git pull/26639/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26639
View PR using the GUI difftool:
$ git pr show -t 26639
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26639.diff
Using Webrev
Link to Webrev Comment