Skip to content

8364722: Parallel: Move CLDG mark clearing to the end of full GC #26637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Aug 5, 2025

Move ClassLoaderDataGraph claim-mark clearing to post_compact (the end of full-gc), to be more aligned with other GCs.

Test: tier1-3


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364722: Parallel: Move CLDG mark clearing to the end of full GC (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26637/head:pull/26637
$ git checkout pull/26637

Update a local copy of the PR:
$ git checkout pull/26637
$ git pull https://git.openjdk.org/jdk.git pull/26637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26637

View PR using the GUI difftool:
$ git pr show -t 26637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26637.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2025

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 5, 2025

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364722: Parallel: Move CLDG mark clearing to the end of full GC

Reviewed-by: tschatzl, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8364722 8364722: Parallel: Move CLDG mark clearing to the end of full GC Aug 5, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 5, 2025
@openjdk
Copy link

openjdk bot commented Aug 5, 2025

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Aug 5, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 5, 2025
Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@albertnetymk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 6, 2025

Going to push as commit 72d1066.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 6, 2025
@openjdk openjdk bot closed this Aug 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 6, 2025
@openjdk
Copy link

openjdk bot commented Aug 6, 2025

@albertnetymk Pushed as commit 72d1066.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Aug 6, 2025

@albertnetymk The command integrate can only be used in open pull requests.

@albertnetymk albertnetymk deleted the pgc-reset-claim branch August 6, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants