Skip to content

8360049: CodeInvalidationReasonTest.java fails with ZGC on AArch64 #25911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Jun 20, 2025

JDK-8359064 introduced a new test (CodeInvalidationReasonTest) which triggers a code path in TestHotSpotVMConfig that had apparently never been run on ZGC+AArch64.
This PR fixes an omission in that code to handle this configuration.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360049: CodeInvalidationReasonTest.java fails with ZGC on AArch64 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25911/head:pull/25911
$ git checkout pull/25911

Update a local copy of the PR:
$ git checkout pull/25911
$ git pull https://git.openjdk.org/jdk.git pull/25911/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25911

View PR using the GUI difftool:
$ git pr show -t 25911

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25911.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2025

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360049: CodeInvalidationReasonTest.java fails with ZGC on AArch64

Reviewed-by: aph, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2025
@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@dougxc The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 20, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 20, 2025
@dougxc
Copy link
Member Author

dougxc commented Jun 20, 2025

Thanks for the revie @shipilev .

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

Going to push as commit ff54a64.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c11f36e: 8356708: C2: loop strip mining expansion doesn't take sunk stores into account
  • 8f121a1: 8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2025
@openjdk openjdk bot closed this Jun 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2025
@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@dougxc Pushed as commit ff54a64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JohnTortugo
Copy link
Contributor

Thank you for fixing @dougxc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants