-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8360049: CodeInvalidationReasonTest.java fails with ZGC on AArch64 #25911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into |
@dougxc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the revie @shipilev . /integrate |
Going to push as commit ff54a64.
Your commit was automatically rebased without conflicts. |
Thank you for fixing @dougxc |
JDK-8359064 introduced a new test (CodeInvalidationReasonTest) which triggers a code path in TestHotSpotVMConfig that had apparently never been run on ZGC+AArch64.
This PR fixes an omission in that code to handle this configuration.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25911/head:pull/25911
$ git checkout pull/25911
Update a local copy of the PR:
$ git checkout pull/25911
$ git pull https://git.openjdk.org/jdk.git pull/25911/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25911
View PR using the GUI difftool:
$ git pr show -t 25911
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25911.diff
Using Webrev
Link to Webrev Comment