8139228: JFileChooser renders file names as HTML document #24439

TejeshR13 · 2025-04-04T07:21:35Z

The rendering of the directory names are handled as JLabel w.r.t Look and feel and also either Details/List view. Though FilePane creates basic rendering for these two few Look and Feel define their own renderers and also ComboBox Directory directory name view. Since HTML filtering is not taken care in any of these renderers, JLabel renders them as HTML document if nothing is set or specified.
The fix is to get "html.disable" property from JFileChooser and set the same to JLabel component which renders and set Directory name. Hence applications can either enable/disable this property and control HTML rendering of directory name.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

JDK-8139228: JFileChooser renders file names as HTML document (Bug - P3)

Reviewers

Phil Race (@prrace - Reviewer)
Alexey Ivanov (@aivanov-jdk - Reviewer) Review applies to 4f8c759a
Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24439/head:pull/24439
$ git checkout pull/24439

Update a local copy of the PR:
$ git checkout pull/24439
$ git pull https://git.openjdk.org/jdk.git pull/24439/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24439

View PR using the GUI difftool:
$ git pr show -t 24439

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24439.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-04-04T07:22:30Z

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-04T07:22:48Z

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8139228: JFileChooser renders file names as HTML document

Reviewed-by: prr, serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 174 new commits pushed to the master branch:

139a05d: 8357176: java.awt javadoc code examples still use Applet API
b1b786a: 8357402: Crash in AdapterHandlerLibrary::lookup
9ca1004: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails
... and 171 more: https://git.openjdk.org/jdk/compare/38bb8adf4f632b08af15f2d8530b35f05f86a020...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-04-04T07:23:25Z

@TejeshR13 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-04-04T07:26:25Z

Webrevs

aivanov-jdk · 2025-04-16T17:50:46Z

/reviewers 2

openjdk · 2025-04-16T17:51:23Z

@aivanov-jdk
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

mrserb · 2025-04-16T22:23:26Z

test/jdk/javax/swing/JFileChooser/HTMLFileName.java

+public class HTMLFileName {
+    static File directory;
+    public static void main(String[] args) throws Exception {
+        String INSTRUCTIONS = """


Why the windows is skipped?
Don't you need to check all L&F and platforms? as of now you validated metal(default on linux) and aqua(default on mac).

Why the windows is skipped?

Because it's impossible to create a file with <html> in the name on Windows.

Don't you need to check all L&F and platforms? as of now you validated metal(default on linux) and aqua(default on mac).

A good point. Validating other L&Fs would be good.

I wonder if the test can be automated, it would make validating all L&F so much easier.

Making an automated test would be difficult, because the text/html is totally OS and L&F dependant. Example without fix in macos the file name will be empty on filepane and in combobox it shows as HTML text. But it doesn't hold the same for other L&F and in linux.

OS or L&F dependant?

macOS uses Aqua by default, Linux uses Metal by default. The behaviour in different L&F could be different.

The test may be customised for a L&F if needed… and it's likely required. I haven't looked into it yet, so I can't suggest anything. Exploring the possibility of making the test automatic is worth the effort.

Dependant on L&F I hope.

> Exception in thread "AWT-EventQueue-0" java.nio.file.InvalidPathException: Illegal char <<> at index 0: <html><h1 color=#ff00ff><font face="Comic Sans MS">SWING ROCKS!!!111 > at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:191) > at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:142) > at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:46) > at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) > at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:203) > at java.base/java.nio.file.Path.of(Path.java:148) > at java.base/java.nio.file.Paths.get(Paths.java:69) > at java.desktop/sun.awt.shell.ShellFolder.getShellFolder(ShellFolder.java:260) > at java.desktop/javax.swing.filechooser.FileSystemView.getShellFolder(FileSystemView.java:724) > at java.desktop/javax.swing.filechooser.FileSystemView.getSystemIcon(FileSystemView.java:242) > at java.desktop/com.sun.java.swing.plaf.windows.WindowsFileChooserUI$WindowsFileView.getIcon(WindowsFileChooserUI.java:1398) > at java.desktop/javax.swing.JFileChooser.getIcon(JFileChooser.java:1614)

This exception looks like a bug? I think if the file was not found then null is an expected result.
For now it can be bypassed by this:

import java.io.File; import java.lang.Override; import javax.swing.Icon; import javax.swing.JFileChooser; import javax.swing.SwingUtilities; import javax.swing.UIManager; import javax.swing.UnsupportedLookAndFeelException; import javax.swing.filechooser.FileSystemView; public class VirtualFileChooser { public static void main(String[] args) throws UnsupportedLookAndFeelException, ClassNotFoundException, InstantiationException, IllegalAccessException { UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsLookAndFeel"); //UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel"); SwingUtilities.invokeLater(() -> { JFileChooser chooser = new JFileChooser(new VirtualFileSystemView()); int result = chooser.showOpenDialog(null); if (result == JFileChooser.APPROVE_OPTION) { File selectedFile = chooser.getSelectedFile(); System.out.println("Selected: " + selectedFile.getAbsolutePath()); } }); } static class VirtualFileSystemView extends FileSystemView { @Override public File createNewFolder(File containingDir) { return null; } @Override public File[] getRoots() { return new File[]{ new File("/", "<html><h1 color=#ff00ff><font face=\"Comic Sans MS\">SWING ROCKS!!!111"), new File("/", "virtualFile2.txt"), new File("/", "virtualFolder") }; } @Override public File getHomeDirectory() { return new File("/"); } @Override public File getDefaultDirectory() { return new File("/"); } @Override public File[] getFiles(File dir, boolean useFileHiding) { // Simulate a virtual folder structure return new File[]{ new File("/", "<html><h1 color=#ff00ff><font face=\"Comic Sans MS\">SWING ROCKS!!!111"), new File(dir, "virtualFile2.txt"), new File(dir, "virtualFolder") }; } @Override public Icon getSystemIcon(File f) { return null; } } }

Note that the bug occurs both in the list of roots (in the dropdown) and in the list of files.

Yes, thank you for the updated virtual test. I've updated the PR with windows L&F fix and also have updated the test too.

@mrserb @aivanov-jdk Can u please re-review the updated changes.

Now @mrserb deserves being a co-author.

aivanov-jdk · 2025-04-17T09:39:18Z

/reviewers 2 reviewer

openjdk · 2025-04-17T09:39:39Z

@aivanov-jdk
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

…_8139228

src/java.desktop/macosx/classes/com/apple/laf/AquaFileChooserUI.java

src/java.desktop/share/classes/sun/swing/FilePane.java

test/jdk/javax/swing/JFileChooser/HTMLFileName.java

aivanov-jdk · 2025-05-20T18:41:22Z

test/jdk/javax/swing/JFileChooser/HTMLFileName.java

+public class HTMLFileName {
+    static File directory;
+    public static void main(String[] args) throws Exception {
+        String INSTRUCTIONS = """


Now @mrserb deserves being a co-author.

test/jdk/javax/swing/JFileChooser/HTMLFileName.java

TejeshR13 · 2025-05-23T16:58:51Z

/integrate

openjdk · 2025-05-23T16:59:18Z

Going to push as commit 917c154.
Since your change was applied there have been 197 commits pushed to the master branch:

2b6b766: 8357581: [JVMCI] Add HotSpotProfilingInfo
a58bfb9: 8357638: Problemlist more Hotspot tests for static JDK
90e076b: 8357654: [BACKOUT] JDK-8343580: Type error with inner classes of generic classes in functions generic by outer
... and 194 more: https://git.openjdk.org/jdk/compare/38bb8adf4f632b08af15f2d8530b35f05f86a020...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-05-23T16:59:27Z

@TejeshR13 Pushed as commit 917c154.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Fix + Manual test

7c190fe

openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025

openjdk bot added the client [email protected] label Apr 4, 2025

prrace approved these changes Apr 14, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 14, 2025

openjdk bot removed the ready Pull request is ready to be integrated label Apr 16, 2025

mrserb reviewed Apr 16, 2025

View reviewed changes

TejeshR13 added 2 commits May 13, 2025 15:57

Fix for windows L&F

cec5dce

Merge branch 'master' of https://git.openjdk.java.net/jdk into branch…

ebe3d91

…_8139228

aivanov-jdk suggested changes May 16, 2025

View reviewed changes

Review fix

d4660c7

aivanov-jdk suggested changes May 20, 2025

View reviewed changes

aivanov-jdk reviewed May 21, 2025

View reviewed changes

test/jdk/javax/swing/JFileChooser/HTMLFileName.java Outdated Show resolved Hide resolved

Updated review comments

4f8c759

aivanov-jdk approved these changes May 21, 2025

View reviewed changes

test/jdk/javax/swing/JFileChooser/HTMLFileName.java Outdated Show resolved Hide resolved

test/jdk/javax/swing/JFileChooser/HTMLFileName.java Outdated Show resolved Hide resolved

test/jdk/javax/swing/JFileChooser/HTMLFileName.java Outdated Show resolved Hide resolved

Updated review comments

5157249

prrace approved these changes May 22, 2025

View reviewed changes

mrserb approved these changes May 22, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 22, 2025

openjdk bot added the integrated Pull request has been integrated label May 23, 2025

openjdk bot closed this May 23, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2025

aivanov-jdk mentioned this pull request May 26, 2025

8357799: Improve instructions for JFileChooser/HTMLFileName.java #25455

Closed

3 tasks

aivanov-jdk mentioned this pull request Jul 4, 2025

8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus LookAndFeel #25907

Closed

3 tasks

8139228: JFileChooser renders file names as HTML document #24439

8139228: JFileChooser renders file names as HTML document #24439

Uh oh!

Conversation

TejeshR13 commented Apr 4, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 4, 2025

Uh oh!

openjdk bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 4, 2025

Uh oh!

mlbridge bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

aivanov-jdk commented Apr 16, 2025

Uh oh!

openjdk bot commented Apr 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrserb May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TejeshR13 commented May 23, 2025

Uh oh!

openjdk bot commented May 23, 2025

TejeshR13 commented Apr 4, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 4, 2025 •

edited

Loading

mlbridge bot commented Apr 4, 2025 •

edited

Loading

aivanov-jdk Apr 17, 2025 •

edited

Loading

mrserb May 13, 2025 •

edited

Loading