Skip to content

keepalive speaker clear datas when stopped#420

Merged
ks-ci-bot merged 1 commit into
openelb:masterfrom
renyunkang:fix_vip
May 29, 2024
Merged

keepalive speaker clear datas when stopped#420
ks-ci-bot merged 1 commit into
openelb:masterfrom
renyunkang:fix_vip

Conversation

@renyunkang

@renyunkang renyunkang commented May 21, 2024

Copy link
Copy Markdown
Member

Description

What type of PR is this ?:

fix: keepalive speaker clear datas when stopped

Related links:

@renyunkang renyunkang requested a review from chaunceyjiang May 21, 2024 09:43
@ks-ci-bot

ks-ci-bot commented May 21, 2024

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot

ks-ci-bot commented May 21, 2024

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2024
chaunceyjiang
chaunceyjiang reviewed May 21, 2024
View reviewed changes
Comment thread pkg/speaker/vip/keepalived.go Outdated
@renyunkang renyunkang added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@renyunkang
speaker clear datas when stopped
8e6318a 
Signed-off-by: renyunkang <rykren1998@gmail.com>
@renyunkang renyunkang removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2024
@renyunkang

renyunkang commented May 23, 2024

Copy link
Copy Markdown
Member Author

kindly ping @chaunceyjiang

chaunceyjiang
chaunceyjiang reviewed May 29, 2024
View reviewed changes

@chaunceyjiang chaunceyjiang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

/lgtm

@ks-ci-bot ks-ci-bot added lgtm Indicates that a PR is ready to be merged. labels May 29, 2024
@ks-ci-bot

ks-ci-bot commented May 29, 2024

Copy link
Copy Markdown
Collaborator

LGTM label has been added.

DetailsGit tree hash: 5d047d0a665408a64d21ea4fbaa7896bfac20170

1 similar comment
@ks-ci-bot

ks-ci-bot commented May 29, 2024

Copy link
Copy Markdown
Collaborator

LGTM label has been added.

DetailsGit tree hash: 5d047d0a665408a64d21ea4fbaa7896bfac20170

@ks-ci-bot ks-ci-bot merged commit 6a53578 into openelb:master May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@chaunceyjiang chaunceyjiang chaunceyjiang left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@chaunceyjiang chaunceyjiang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@renyunkang @ks-ci-bot @chaunceyjiang