-
Notifications
You must be signed in to change notification settings - Fork 142
refactor: replace injectIntl with useIntl #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @anmolsah! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@anmolsah We need a signed Contributor Agreement from you before we can review this. Thanks. |
I have signed the CLA. Please recheck. |
@@ -98,7 +98,6 @@ const CourseChecklist = ({ | |||
CourseChecklist.propTypes = { | |||
courseId: PropTypes.string.isRequired, | |||
// injected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont forget to remove the // injected
comment related to the intl
prop, I see it in some of the modified files.
Hi @anmolsah, thanks for this contribution. The checks are failing due to some linting and formatting issues, please take a look. You can use the |
I'm currently facing issues while installing the project dependencies on my local Windows machine. Running npm ci throws permission errors, and attempting to run ESLint results in memory-related crashes and unknown read errors from some config files. I would appreciate any guidance or suggestions on how to properly set up the project on Windows. Please let me know if there are any known steps or workarounds for this environment. |
Description
This pull request replaces the deprecated
injectIntl
higher-order component with the modernuseIntl
hook from@edx/frontend-platform/i18n
across multiple components.This is part of the ongoing effort described in #2280 to modernize the internationalization approach across the codebase and improve compatibility with React functional components.
Files Refactored:
src/generic/SaveFormConnectionErrorAlert.jsx
src/editors/sharedComponents/CodeEditor/index.jsx
src/editors/containers/GameEditor/index.jsx
src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/settingsComponents/Randomization/index.jsx
src/generic/configure-modal/VisibilityTab.jsx
src/export-page/export-footer/ExportFooter.jsx
src/studio-home/tabs-section/courses-tab/contact-administrator/index.jsx
src/editors/containers/VideoEditor/components/VideoSettingsModal/components/SocialShareWidget/index.jsx
src/course-checklist/CourseChecklist.jsx
src/pages-and-resources/discussions/app-list/AppCard.jsx
src/files-and-videos/generic/UsageMetricsMessage.jsx
src/editors/containers/VideoEditor/components/VideoSettingsModal/components/DurationWidget/index.jsx
src/files-and-videos/generic/FileMenu.jsx
src/schedule-and-details/introducing-section/index.jsx
Impacted User Roles
There are no user-facing UI or design changes—only internal refactoring to improve maintainability and remove deprecated patterns.
Supporting information
This change is part of:
Other information
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review: