Skip to content

fix: pages and resources plugins not rendered #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented Apr 30, 2025

Description

A recent refactor cleaned up the Pages and Resources plugin slots but introduced an issue where the plugins were no longer being rendered

@jansenk jansenk changed the title test: reproduce issue fix: pages and resources plugins not rendered Apr 30, 2025
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you!

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (65aca04) to head (c2b13ed).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1885    +/-   ##
========================================
  Coverage   93.77%   93.78%            
========================================
  Files        1146     1146            
  Lines       23898    23896     -2     
  Branches     5042     5161   +119     
========================================
- Hits        22411    22410     -1     
+ Misses       1419     1409    -10     
- Partials       68       77     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brian-smith-tcril brian-smith-tcril merged commit 484154b into openedx:master Apr 30, 2025
7 checks passed
brian-smith-tcril pushed a commit to brian-smith-tcril/frontend-app-course-authoring that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants