Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Conversation

@bowenlan-amzn
Copy link
Contributor

@bowenlan-amzn bowenlan-amzn commented Dec 30, 2020

Issue #, if available:

Description of changes:

Consume cluster setting opendistro.index_state_management.snapshot.deny_list from Runner, pass it to Snapshot Step, will block any snapshot repository if it matches with the prefix in the cluster setting.

We cannot directly consume this cluster setting in Snapshot Step, since it is not instantiate when the plugin started, it can only start to consume cluster setting when it's instantiated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #366 (ce961f8) into master (ae97e5a) will increase coverage by 0.34%.
The diff coverage is 96.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #366      +/-   ##
============================================
+ Coverage     76.21%   76.55%   +0.34%     
- Complexity     1455     1457       +2     
============================================
  Files           188      188              
  Lines          7314     7332      +18     
  Branches       1186     1187       +1     
============================================
+ Hits           5574     5613      +39     
+ Misses         1096     1078      -18     
+ Partials        644      641       -3     
Impacted Files Coverage Δ Complexity Δ
...atemanagement/step/snapshot/AttemptSnapshotStep.kt 90.27% <95.45%> (+1.38%) 10.00 <1.00> (+2.00)
...ticsearch/indexmanagement/IndexManagementPlugin.kt 92.17% <100.00%> (+0.06%) 11.00 <0.00> (ø)
...exstatemanagement/settings/ManagedIndexSettings.kt 98.71% <100.00%> (+0.12%) 1.00 <0.00> (ø)
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 78.35% <100.00%> (+0.11%) 88.00 <1.00> (+1.00)
...nt/indexstatemanagement/model/destination/Slack.kt 40.90% <0.00%> (-13.64%) 2.00% <0.00%> (-2.00%)
...icsearch/indexmanagement/rollup/model/ISMRollup.kt 92.66% <0.00%> (-1.84%) 29.00% <0.00%> (-2.00%)
...agement/indexstatemanagement/ManagedIndexRunner.kt 55.65% <0.00%> (+0.61%) 41.00% <0.00%> (ø%)
...anagement/indexstatemanagement/model/Transition.kt 67.69% <0.00%> (+3.07%) 5.00% <0.00%> (ø%)
...adata/TransportUpdateManagedIndexMetaDataAction.kt 88.88% <0.00%> (+3.70%) 10.00% <0.00%> (+1.00%)
...statemanagement/model/destination/CustomWebhook.kt 94.20% <0.00%> (+28.98%) 14.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae97e5a...ce961f8. Read the comment docs.

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review December 30, 2020 05:46
@bowenlan-amzn bowenlan-amzn added the enhancement An improvement on the existing feature’s functionalities label Jan 5, 2021
@bowenlan-amzn bowenlan-amzn merged commit ff33f16 into opendistro-for-elasticsearch:master Jan 7, 2021
@bowenlan-amzn bowenlan-amzn deleted the snapshotdenylist branch January 8, 2021 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement An improvement on the existing feature’s functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants