[1.4] fix fd leaks and detect them as comprehensively as possible #5034
+222
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
approved these changes
Nov 20, 2025
cyphar
changed the title
Co-authored-by: Aleksa Sarai <[email protected]> Signed-off-by: lifubang <[email protected]> (cherry picked from commit ba7f46d) Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]> (cherry picked from commit e027288) Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]> (cherry picked from commit 9a5e626) Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]> (cherry picked from commit 0127cc6) Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]> (cherry picked from commit d870650) Signed-off-by: lifubang <[email protected]>
lifubang
force-pushed
the
ci-detect-fdleak-try-best-1.4
branch
from
4e0fea6 to
e675743
Compare
AkihiroSuda
approved these changes
Nov 26, 2025
Merged
Merged
smallprogram
added a commit
to smallprogram/openwrt_packages
that referenced
this pull request
Jan 29, 2026
cgroups: provide iocost statistics for cgroupv2. (opencontainers/cgroups#43) cgroups: retry DBus connection when it fails with EAGAIN.(opencontainers/cgroups#45) cgroups: improve cpuacct.usage_all resilience when parsing data from patched kernels (such as the Tencent kernels). (opencontainers/cgroups#46,opencontainers/cgroups#50) libct: close child fds on prepareCgroupFD error. (opencontainers/runc#4936) libct: fix mips compilation. (opencontainers/runc#4962, opencontainers/runc#4967) When configuring a tmpfs mount, only set the mode= argument if the target path already existed. This fixes a regression introduced in our CVE-2025-52881 mitigation patches. (opencontainers/runc#4971, opencontainers/runc#4976) Fix various file descriptor leaks and add additional tests to detect them as comprehensively as possible. (opencontainers/runc#5007, opencontainers/runc#5021, opencontainers/runc#5034) The "hallucination" helpers added as part of the CVE-2025-52881 mitigation have been made more generic and now apply to all of our pathrs helper functions, which should ensure we will not regress dangling symlink users. (opencontainers/runc#4985) Signed-off-by: David Mandy <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport: #5026
Fix: #5021
Fix: #5007
Close: #5022
Close: #5024
Without deferring the closure of this file descriptor, starting a container with a very large number of devices can hit the
RLIMIT_NOFILElimit.