small fix based on pullapprove document #38
Conversation
Other projects may refer to template's pullapprove config file. I think we'd better based on pullapprove's document. This will reduce doubts of pullapprove grammar. Signed-off-by: Ma Shimiao <[email protected]>
There was a problem hiding this comment.
The always_pending move is basically reverting a5e7e37 from #29. As I said in that commit message, I think we want always_pending under group_defaults because it's a group setting.
I don't really mind about quoting or not. We haven't quoted since .pullapprove.yml landed in 5b3d5d5, but I don't have a problem with adding quoting now.
.pullapprove.yml
Outdated
| @@ -4,19 +4,20 @@ requirements: | |||
| signed_off_by: | |||
| required: true | |||
|
|
|||
| always_pending: | |||
| title_regex: '^WIP' | |||
| explanation: 'Work in progress...' | |||
There was a problem hiding this comment.
This line needs a two-space indent (not a four-space indent) for this to be valid YAML.
There was a problem hiding this comment.
Oh!!! Thanks, updated.
But it's still very strange. selinux-maintainers really exists on opencontaienrs repo, but pullapprove says not.
There was a problem hiding this comment.
selinux-maintainersreally exists on opencontaienrs repo, but pullapprove says not.
PullApprove says:
selinux-maintainers team not found on this repo
And looking at our selinux repo, it looks like the group is go-selinux-maintainers (e.g. see here and here). I've filed #39 to catch up with the current group name, but the org admins may want to rename the group to match the current repo name.
There was a problem hiding this comment.
That's why I said very strange. At https://github.com/orgs/opencontainers/teams/, we can say selinux-maintainers exists. go-selinux-maintainers does not exist.
Mashimiao
force-pushed
the
pullapprove-fix
branch
from
75ff7db to
4f44b40
Compare
Other projects may refer to template's pullapprove config file.
I think we'd better based on pullapprove's document.
This will reduce doubts of pullapprove grammar.
Signed-off-by: Ma Shimiao [email protected]