-
Notifications
You must be signed in to change notification settings - Fork 35
Apply default actions to default roles for new events/series #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Apply default actions to default roles for new events/series #1360
Conversation
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
This pull request is deployed at test.admin-interface.opencast.org/1360/2025-07-09_13-08-41/ . |
I tried to test this PR, but when I open the new series dialogue, I can't define the metadata and proceed to the next step. I tried it with the same result in both our test environment and https://develop.opencast.org |
Likely fixed by #1340 |
You are right, if I add this commit, I'm again able to create series. However, I found an other problem. The custom actions are now added correctly for the default user. However, if I change the ACL template, the custom actions are removed again from the default user. This happens not only with new series, but also with existing ones. Additionally, when I change the template of an existing series, all the user ACLs are removed and only the editor's user ACL is added. |
ee043ea
to
242e534
Compare
Thanks for catching that, should be fixed now.
Afaik when switching templates, all changes made by the user are discarded. So after switching a template, only the roles specified by the template + the default user role are set. Wether that constitutes reasonable behaviour or not I cannot say. In any case, that discussion is probably better left for a different issue/PR. |
In our case, we use the templates to regulate the access authorizations for Tobira. We use templates that contain roles which grant permissions based on users' organizational affiliations. For example, this means that we can only allow members of our institution to access certain series/events in Tobira. By the way, in the old admin UI, user ACLs weren't removed when changing the template. New issue to fix this: #1364 |
As you mentioned in #1364, configuring |
Thanks for catching that, should be fixed now. |
Thanks @Arnei for fixing this. Default actions are now applied as expected and the configuration of |
This pull request has conflicts ☹ |
b69c69b
to
500c55d
Compare
This pull request has conflicts ☹ |
Fixes opencast#1354. An admin can configure actions that are automatically added to each role you add to an ACL in the ACL tab for series and events. However, they were not applied to default user role the ACL is initialized with. This adds the actions to default user role.
When switching between ACL templates, we were keeping the default user as intended, but the default user lost their default actions (if configured). This fixes that.
The acl config defaults were not always fetched for the acl tab. This should fix that.
500c55d
to
2ba415a
Compare
Fixes #1354.
An admin can configure actions that are automatically added to each role you add to an ACL in the ACL tab for series and events. However, they were not applied to default user role the ACL is initialized with. This adds the actions to default user role.
How to test this
Configure additional actions in your Opencast configuration. Check
etc/listproviders/acl.additional.actions.properties
andetc/listproviders/acl.default.create.properties
and configure an action there. Then try creating an event and a series.