Skip to content

fix: Don't crash when a null is in an enum (fixes #500). Thanks @juspence! #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2021

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Sep 26, 2021

No description provided.

@dbanty dbanty added this to the 0.10.5 milestone Sep 26, 2021
@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #501 (8779620) into main (5861c7c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #501   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         1609      1610    +1     
=========================================
+ Hits          1609      1610    +1     
Impacted Files Coverage Δ
...penapi_python_client/parser/properties/__init__.py 100.00% <ø> (ø)
...i_python_client/parser/properties/enum_property.py 100.00% <100.00%> (ø)
...on_client/schema/openapi_schema_pydantic/schema.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5861c7c...8779620. Read the comment docs.

@dbanty dbanty merged commit 2d4365c into main Sep 26, 2021
@dbanty dbanty deleted the 500-dont-crash-on-null-enum-value branch September 26, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant