-
Notifications
You must be signed in to change notification settings - Fork 9
Keep network inspector at top or bottom if scrolled to end #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements automatic scroll position maintenance in the Network Inspector sidebar, ensuring that when users are viewing the most recent items (top in reverse-chronological sort or bottom in chronological sort), the view automatically scrolls to keep new network requests visible as they arrive.
Key Changes:
- Adds scroll position tracking to detect when the user is viewing the top or bottom of the list
- Implements automatic scrolling behavior when new network requests arrive and the user is at the relevant edge
- Refactors placeholder text logic for better code organization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
snapo-app-mac/Snap-O/NetworkInspector/NetworkInspectorSidebarList.swift
Outdated
Show resolved
Hide resolved
snapo-app-mac/Snap-O/NetworkInspector/NetworkInspectorSidebarList.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
snapo-app-mac/Snap-O/NetworkInspector/NetworkInspectorSidebarList.swift
Outdated
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Testing
Checklist