Skip to content

Conversation

@amandeep-oai
Copy link
Contributor

@amandeep-oai amandeep-oai commented Dec 10, 2025

Summary

  • When the user is looking at the top/bottom in reverse-chron/chron sort, respectively, when new network requests come in, we should stay at the top/bottom so we can see the new request without having to scroll.
  • When the user isn't at the top or bottom, then no change in behavior.

Testing

  • Built and ran Snap-O locally
  • Added or updated tests (if applicable)

Checklist

@amandeep-oai amandeep-oai changed the title sticky_top_bottom Keep network inspector at top or bottom if scrolled to end Dec 10, 2025
@amandeep-oai amandeep-oai marked this pull request as ready for review December 10, 2025 09:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements automatic scroll position maintenance in the Network Inspector sidebar, ensuring that when users are viewing the most recent items (top in reverse-chronological sort or bottom in chronological sort), the view automatically scrolls to keep new network requests visible as they arrive.

Key Changes:

  • Adds scroll position tracking to detect when the user is viewing the top or bottom of the list
  • Implements automatic scrolling behavior when new network requests arrive and the user is at the relevant edge
  • Refactors placeholder text logic for better code organization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@amandeep-oai amandeep-oai requested a review from Copilot December 10, 2025 10:27
@amandeep-oai
Copy link
Contributor Author

@codex review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants