Make Runner an abstract base class #720
Merged
+2,309
−2,055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce a DEFAULT_RUNNER global and a set_default_runner() function to allow callers to specify a default Runner for agent runs. - Update Runner.run, run_sync, and run_streaming to use DEFAULT_RUNNER if set, otherwise fallback to DefaultRunner. - Add detailed docstrings to run, run_sync, and run_streaming methods for clarity on agent execution flow and exceptions.
This commit renames the abstract and concrete methods run_impl, run_sync_impl, and run_streamed_impl in the Runner and DefaultRunner classes to _run_impl, _run_sync_impl, and _run_streamed_impl (or _start_streaming as appropriate) for improved naming consistency. Updates all method calls and test mocks accordingly. No behavior changes.
…lace global with accessor - Move TraceProvider and related logic from setup.py to new provider.py module - Replace direct GLOBAL_TRACE_PROVIDER references with get_trace_provider() accessor throughout tracing code - Update init and util imports to use get_trace_provider - Call set_trace_provider(TraceProvider()) on init - Remove ID and time generation logic from util, delegate to TraceProvider - Update SpanImpl to always use passed-in span_id
|
This PR is stale because it has been open for 10 days with no activity. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
…mplementation - Add abstract TraceProvider base class to define tracing API - Move default tracing logic to DefaultTraceProvider - Update __init__.py to export both TraceProvider and DefaultTraceProvider, and use DefaultTraceProvider as default - Aligns span/trace management and enables alternative provider implementations
# Conflicts: # src/agents/__init__.py # src/agents/run.py
…itialized - Add get_default_runner to retrieve current default runner. - Always assign DEFAULT_RUNNER to a DefaultRunner at module init. - Replace fallback logic (`DEFAULT_RUNNER or DefaultRunner()`) with direct use of initialized DEFAULT_RUNNER. - Update __all__ in __init__.py to export get_default_runner. - Minor update to tracing/__init__.py __all__ for consistency.
…ls, _get_model) from DefaultRunner to Runner base class
## Summary - rename DefaultRunner to DefaultAgentRunner and extend new AgentRunner base - remove `set_default_runner`/`get_default_runner` helpers - rename abstract methods on AgentRunner (no underscore) - update tests and imports for new API ## Testing - `make format` - `make lint` - `make mypy` - `make tests` ------ https://chatgpt.com/codex/tasks/task_i_6851851acce8832099adc70d8197016c
…imports and __all__ entries
…rder in voice workflow tests
rm-openai
approved these changes
Jun 17, 2025
src/agents/run.py
Outdated
| class Runner: | ||
| class Runner(abc.ABC): | ||
| @abc.abstractmethod | ||
| async def _run_impl( |
There was a problem hiding this comment.
if these are meant to be overriden, we should remove the _ and document them
There was a problem hiding this comment.
not there anymore
src/agents/run.py
Outdated
| """The ID of the previous response, if any.""" | ||
|
|
||
|
|
||
| class AgentRunner(abc.ABC): |
There was a problem hiding this comment.
Can you add a comment saying this is not part of public interface, and that you should not use/subclass it? (We'll change that in the future once we feel better about it)
| @@ -0,0 +1,294 @@ | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
if possible can you try and mark as a "move" so blame is preserved?
# Conflicts: # src/agents/run.py
…UNNER to new AgentRunner if passed None conftest.py: add autouse fixture to clear DEFAULT_AGENT_RUNNER before each test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows replacing the runner and trace provider logic.