Skip to content

Adds PR template per contributing guidelines #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

peterramsing
Copy link
Contributor

What:

  • Bug Fix
  • New Feature
  • Docs

Description:

The CONTRIBUTING.md file links to the PR template that isn't there. This adds the one used from PEST and I added a docs line as well.

@peterramsing
Copy link
Contributor Author

One thing about this PR template is that it shows tasks as "undone". There might be a better way to do that but before I reinvent what is there in Pest I'll let it be for now.
Screenshot 2024-10-31 at 08 08 51

Copy link
Collaborator

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! - minor typo

Copy link
Collaborator

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot I could just fix easy typos in PRs :) - fixed and merging.

@iBotPeaches iBotPeaches merged commit 589cf3a into openai-php:main Apr 8, 2025
29 checks passed
@iBotPeaches
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants