fix: remove System.out and System.err call in tests #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhangjian
reviewed
Jul 13, 2024
| @Override | ||
| public CompletableFuture<Void> writeBatch(String database, List<Point> points) { | ||
| StringJoiner sj = new StringJoiner("\n"); | ||
| StringJoiner sj = new StringJoiner(System.lineSeparator()); |
Member
There was a problem hiding this comment.
It's not platform independent, it's always \n
Contributor
Author
There was a problem hiding this comment.
We will roll back this piece of code.
hezhangjian
reviewed
Jul 13, 2024
| if (trustManagers[0] instanceof X509TrustManager) { | ||
| x509TrustManager = (X509TrustManager) trustManagers[0]; | ||
| } else { | ||
| throw new OpenGeminiException("The trust manager is not an instance of X509TrustManager"); |
Member
There was a problem hiding this comment.
I prefer to trhow IllegalStateException here.
Contributor
Author
There was a problem hiding this comment.
We will roll back this piece of code.
instpe
force-pushed
the
fix_code_style
branch
2 times, most recently
from
8623f45 to
c6709c0
Compare
Signed-off-by: wei <[email protected]>
hezhangjian
changed the title
hezhangjian
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #55