Skip to content

fix: modify encoder according to line protocol. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hezhangjian merged 1 commit into from
Sep 8, 2024
Merged

fix: modify encoder according to line protocol. #172

hezhangjian merged 1 commit into from
Sep 8, 2024
+40 −29

Conversation

@Chenxulin97
Copy link
Member

@Chenxulin97 Chenxulin97 commented Aug 25, 2024

Fix #160

@Chenxulin97
Copy link
Member Author

Chenxulin97 commented Aug 25, 2024

I will add some unit test later.

@Chenxulin97 Chenxulin97 marked this pull request as draft August 25, 2024 15:37
@hezhangjian
Copy link
Member

hezhangjian commented Aug 27, 2024

We need add tests to ensure key is not encoded

@Chenxulin97 Chenxulin97 marked this pull request as ready for review September 8, 2024 04:47
@hezhangjian hezhangjian merged commit baf8764 into openGemini:main Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hezhangjian hezhangjian hezhangjian approved these changes

@xuthus5 xuthus5 xuthus5 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implementation of line protocol encoding looks a bit strange

3 participants

@Chenxulin97 @hezhangjian @xuthus5