proposal: redefine show tag keys, tag values, field keys api #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Chenxulin97 @shoothzj PTAL, thanks. |
Member
|
Great work! I prefer |
xuthus5
force-pushed
the
proposal/command_builder
branch
2 times, most recently
from
7c2420c to
c654b26
Compare
Member
Author
|
The builder may not be perfect, but we can improve it based on requirements and issues. |
CoulsonYing
added a commit
to CoulsonYing/opengemini-client-go
that referenced
this pull request
Jul 28, 2024
Signed-off-by: coulsonying <[email protected]>
Chenxulin97
approved these changes
Aug 18, 2024
Chenxulin97
reviewed
Aug 18, 2024
xuthus5
force-pushed
the
proposal/command_builder
branch
5 times, most recently
from
0997704 to
6321afd
Compare
Signed-off-by: Young Xu <[email protected]>
xuthus5
force-pushed
the
proposal/command_builder
branch
from
6321afd to
4e2c38a
Compare
hezhangjian
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to better understand and use APIs, we should have clear and simple API usage tutorials and tools to help users build their own applications. However, so far, the instructions for using the APIs
ShowTagKeys,ShowTagValues, andShowFieldKeysare vague, and users have no idea how to use the APIs. We need to inform users how to generate the command parameters of each API and what the return value means.I have temporarily written comments for these APIs and created their builders to quickly generate simple query SQL.