⚡ Switch from prefork to threads for Celery concurrency#375
Closed
stevenbal wants to merge 3 commits into
Closed
Conversation
because Open Notificaties is primarily I/O bound, the Celery workers could spend a decent amount of time waiting, and in this scenario it is more efficient to use threads because they have a lower memory footprint than processes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 124 124
Lines 4231 4231
Branches 666 666
=======================================
Hits 3964 3964
Misses 205 205
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
this allows more proper simulation of timeouts, without limiting the concurrency of the webhook itself
952bbd0 to
957c662
Compare
Contributor
Author
|
Closing this in favor of #364 since that also introduces the same change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Open Notificaties is primarily I/O bound, the Celery workers could spend a decent amount of time waiting, and in this scenario it is more efficient to use threads because they have a lower memory footprint than processes
TODO:
Changes
Checklist
Check off the items that are completed or not relevant.
Experimental features/changes
docs/api/experimental.rstpageCommit hygiene