Skip to content

Conversation

@lmolkova
Copy link
Member

A trivial PR adding a few debug logs to help understand where weaver config comes from.

E.g. when running live-check with --format json --templates ./templates

Using local templates from `./templates/json`
Searching for Weaver configuration from weaver.yaml at "/Users/lmolkova/repo/weaver-live-demo/templates/json"
Loaded Weaver configuration from /Users/lmolkova/repo/weaver-live-demo/templates/json/weaver.yaml

no format/no templates

No local templates found at `ansi`. Using embedded templates.
Searching for Weaver configuration from weaver.yaml at "ansi"
Loaded Weaver configuration from ansi/weaver.yaml

Could be better but helps to learn there are embedded configs and templates and shows which config is loaded.

@lmolkova lmolkova requested a review from a team as a code owner September 13, 2025 00:17
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lquerel
Copy link
Contributor

lquerel commented Sep 15, 2025

@lmolkova you should run cargo fmt to make the build happy and after that should be mergeable.

@lmolkova
Copy link
Member Author

thanks @lquerel, updated

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.9%. Comparing base (cf8a61e) to head (f838e48).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_forge/src/config.rs 83.3% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #934     +/-   ##
=======================================
- Coverage   77.9%   77.9%   -0.1%     
=======================================
  Files         76      76             
  Lines       5972    5980      +8     
=======================================
+ Hits        4658    4662      +4     
- Misses      1314    1318      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsuereth jsuereth merged commit 161a61b into open-telemetry:main Sep 15, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants