Skip to content

Fix #864 - Always serialize a brief and registry_url #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsuereth merged 2 commits into from
Sep 15, 2025
Merged

Fix #864 - Always serialize a brief and registry_url #929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c813a3b
Fix #864 - Always serialize a brief and registry_url
jsuereth Sep 10, 2025
09a57ee
Merge branch 'main' into fix-864
jsuereth Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions crates/weaver_resolved_schema/src/registry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ use weaver_semconv::YamlValue;
#[serde(deny_unknown_fields)]
pub struct Registry {
/// The semantic convention registry url.
#[serde(skip_serializing_if = "String::is_empty")]
pub registry_url: String,
/// A list of semantic convention groups.
pub groups: Vec<Group>,
Expand All @@ -53,7 +52,6 @@ pub struct Group {
/// The type of the group including the specific fields for each type.
pub r#type: GroupType,
/// A brief description of the semantic convention.
#[serde(skip_serializing_if = "String::is_empty")]
pub brief: String,
/// A more elaborate description of the semantic convention.
/// It defaults to an empty string.
Expand Down
Loading