Fix #750 - Dual registry resolves incorrectly #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lquerel
commented
May 27, 2025
Comment on lines
+498
to
+501
| assert_eq!(metric.attributes.len(), 3); | ||
| assert!(attr_names.contains("auction.name")); | ||
| assert!(attr_names.contains("auction.id")); | ||
| assert!(attr_names.contains("error.type")); |
Contributor
Author
There was a problem hiding this comment.
The previous version of this was definitely not strong enough...
jerbly
approved these changes
May 27, 2025
Contributor
jerbly
left a comment
jerbly
left a comment
There was a problem hiding this comment.
Probably worth mentioning this fix in the changelog.
jsuereth
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug does not appear when:
gc_unreferenced_attribute_refsWhen two registries are involved and
gc_unreferenced_attribute_refsis called (i.e., without the--include-unreferencedparameter), resolution sometimes succeeds and sometimes fails. The intermittent success occurs becauseHashMapordering in Rust is random, and the small number of elements in the test frequently resulted in the expected outcome. Additionally, the initial test was insufficiently robust.The source of the bug lies in the
AttributeCatalog::gc_unreferenced_attribute_refsmethod, which returned the correct mapping but did not internally modify the catalog as intended... Pretty bad!Closes #750