-
Notifications
You must be signed in to change notification settings - Fork 60
Update semconv JSON schema for entities #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add `entity_associations` for metrics - Update `display_name` description to be more generic - Replace resource with updated entity schema
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
=======================================
- Coverage 77.2% 77.1% -0.1%
=======================================
Files 66 66
Lines 5224 5224
=======================================
- Hits 4033 4032 -1
- Misses 1191 1192 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsuereth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this! A few comments on what we can/should support right now.
|
@jsuereth I'll keep the parts that don't exist yet in this PR and move it to draft. I'll open a new PR with the remaining changes that can be made now. Thanks for looking! |
|
Please see: #735 I'm actually changing how we plan to do descriptive and identifying attributes for various internal reasons around attribute sharing in Weaver. |
jsuereth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now, but you probably need to merge in main, where role was already added.
entity_associationsfor metricsdisplay_namedescription to be more genericTo try this out in VS Code, update the .vscode/settings.json in your semconv checkout to point to
"../weaver/schemas/semconv.schema.json", assuming your weaver and semconv checkouts are in sibling directories. You may need to close and reopen the semconv window.When this is merged and a release happens a PR to semconv can be made to update the version of the JSON schema.