Skip to content

Conversation

@smith
Copy link
Contributor

@smith smith commented May 7, 2025

  • Add entity_associations for metrics
  • Update display_name description to be more generic
  • Replace resource with updated entity schema

To try this out in VS Code, update the .vscode/settings.json in your semconv checkout to point to "../weaver/schemas/semconv.schema.json", assuming your weaver and semconv checkouts are in sibling directories. You may need to close and reopen the semconv window.

When this is merged and a release happens a PR to semconv can be made to update the version of the JSON schema.

- Add `entity_associations` for metrics
- Update `display_name` description to be more generic
- Replace resource with updated entity schema
@smith smith requested a review from a team as a code owner May 7, 2025 03:26
@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.1%. Comparing base (2cbc3ff) to head (3f693b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #731     +/-   ##
=======================================
- Coverage   77.2%   77.1%   -0.1%     
=======================================
  Files         66      66             
  Lines       5224    5224             
=======================================
- Hits        4033    4032      -1     
- Misses      1191    1192      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! A few comments on what we can/should support right now.

@smith
Copy link
Contributor Author

smith commented May 7, 2025

@jsuereth I'll keep the parts that don't exist yet in this PR and move it to draft. I'll open a new PR with the remaining changes that can be made now. Thanks for looking!

@smith smith marked this pull request as draft May 7, 2025 16:35
@jsuereth
Copy link
Contributor

Please see: #735

I'm actually changing how we plan to do descriptive and identifying attributes for various internal reasons around attribute sharing in Weaver.

@smith
Copy link
Contributor Author

smith commented May 12, 2025

@jsuereth I added role as an enum in 590113d. Let me know if things look right here now, as I also took out the things that don't exist yet.

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, but you probably need to merge in main, where role was already added.

@smith smith marked this pull request as ready for review May 17, 2025 02:57
@jsuereth jsuereth enabled auto-merge (squash) May 27, 2025 18:42
@jsuereth jsuereth merged commit 1d41c86 into open-telemetry:main May 27, 2025
20 checks passed
@smith smith deleted the nls/schema-updates branch May 27, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants