Skip to content

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Aug 22, 2025

Progresses #2334

Changes

Records the type of deployment occuring so that provisioning of a new instance running the software can be differentiated from adding the files to a store.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

stability: development
- id: provision
value: 'provision'
brief: The software is being provisioned on a machine aka the target.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having a hard time finding the difference between these two. Could you elaborate more? I'm also having a hard time finding how this attribute would be useful/used in reality. Can you maybe add use-case for it, or any instrumentation already using it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A scenario is within your cicd pipeline you could publish your artifact's to a registry/store for instance docker hub if building a container or could be provisioning a container instance running the artifact's.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe there is industry-wide notion of deployment type that is also known and available inside ci/cd pipeline. It's not clear how existing tooling would populate this attribute. The type is also a very broad term that could mean a lot of things, including k8s deployment strategy or similar Azure DevOps thing.

Defining semantic conventions usually means researching how things are done in multiple environments, finding commonalities, ensuring information is available and then documenting how to capture new things in these different environments.

Currently it seems we're inventing something new that is not widely applicable. It goes against best practices documented in this repo

- When defining a broad attribute applicable across multiple domains or systems,
check for existing standards or widely accepted best practices in the industry.
Avoid creating generic attributes that are not based on established standards.

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2674 (review) for the reasoning

@github-project-automation github-project-automation bot moved this from Untriaged to Blocked in Semantic Conventions Triage Aug 25, 2025
@lmolkova lmolkova added the experts needed This issue or pull request is outside an area where general approvers feel they can approve label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:deployment enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve
Projects
Development

Successfully merging this pull request may close these issues.

3 participants