Skip to content

Registry - fix link for .NET AWS Instrumentation package#3156

Merged
chalin merged 1 commit intoopen-telemetry:mainfrom
Kielek:dotnet-aws-instrumentation-fix-link
Aug 11, 2023
Merged

Registry - fix link for .NET AWS Instrumentation package#3156
chalin merged 1 commit intoopen-telemetry:mainfrom
Kielek:dotnet-aws-instrumentation-fix-link

Conversation

@Kielek
Copy link
Copy Markdown
Member

@Kielek Kielek commented Aug 11, 2023

@Kielek Kielek requested a review from a team August 11, 2023 07:04
@Kielek
Copy link
Copy Markdown
Member Author

Kielek commented Aug 11, 2023

Links checker is not verifying links in registry-yaml files.

I think it can be handled as a separate issue.

Copy link
Copy Markdown
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@chalin
Copy link
Copy Markdown
Contributor

chalin commented Aug 11, 2023

Links checker is not verifying links in registry-yaml files

The issue is that the link check is currently ignoring links into github:

# Ignore links to GH repo content for now.
- ^https?://github\.com/.*?/.*?/(blob|tree)/

The reason I've done that is because our refcache has grown considerably, and because of that the link-checking GH action over 2 min. I have a task open to address this -- e.g., #2554.

@chalin chalin merged commit ad9ebd5 into open-telemetry:main Aug 11, 2023
@Kielek Kielek deleted the dotnet-aws-instrumentation-fix-link branch August 11, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants