-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Python: add installation instructions, refine status info, and more #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chalin
merged 4 commits into
open-telemetry:main
from
chalin:chalin-python-installation-2022-02-09
Feb 11, 2022
Merged
Python: add installation instructions, refine status info, and more #1116
chalin
merged 4 commits into
open-telemetry:main
from
chalin:chalin-python-installation-2022-02-09
Feb 11, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2022
codeboten
reviewed
Feb 9, 2022
a3e7e7b
to
400d7f5
Compare
chalin
commented
Feb 10, 2022
lzchen
reviewed
Feb 10, 2022
lzchen
reviewed
Feb 10, 2022
400d7f5
to
8a0fdc7
Compare
@lzchen @codeboten @cartermp et all: anything else? Is this ready for a final approval? |
cartermp
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
codeboten
approved these changes
Feb 11, 2022
codeboten
reviewed
Feb 11, 2022
lzchen
approved these changes
Feb 11, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-1116--opentelemetry.netlify.app/docs/instrumentation/python/
/cc @open-telemetry/python-approvers