Fixes missing Copyright holder#23
Conversation
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
We don't modify this file in any other repo. Is this something that we should do?
|
I think we don't need to modify the LICENSE file |
|
@bogdandrutu I don't think it hurts to have it fixed. Definitely looks better without the placeholder |
|
Do you know if other projects do the same? Or this should be a standard format? |
|
It's a placeholder that is often overseen. I don't know the legal implications but the intent of the placeholder was clearly to be replaced :) |
SergeyKanzhelev
left a comment
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
Actually reading it again - it is a license text that tells how to apply this license. So it should stay generic with the placeholder.
|
@danielkhan please re-open if you feel it needs to be changed. |
|
I think you are right, @SergeyKanzhelev. While there are projects that filled it out, like https://github.com/istio/istio/blob/master/LICENSE#L190, the majority hasn't. |
…late Add CHANGELOG.md template
…en-telemetry#23) Co-authored-by: Josh Suereth <joshuasuereth@google.com> Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
3 participants
No description provided.