Skip to content

chore(sampling): move sdk types from opentelemetry to opentelemetry_sdk#3277

Merged
cijothomas merged 1 commit intoopen-telemetry:mainfrom
bantonsson:ban/remove-sampling-from-api
Dec 3, 2025
Merged

chore(sampling): move sdk types from opentelemetry to opentelemetry_sdk#3277
cijothomas merged 1 commit intoopen-telemetry:mainfrom
bantonsson:ban/remove-sampling-from-api

Conversation

@bantonsson
Copy link
Contributor

@bantonsson bantonsson commented Dec 3, 2025

Fixes #2753

Changes

Moves the following SDK sampling types from opentelemetry::trace to opentelemetry_sdk::trace:

  • SamplingDecision, SamplingResult
  • These types are SDK implementation details and should be imported from opentelemetry_sdk::trace instead.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@bantonsson bantonsson self-assigned this Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.7%. Comparing base (483b420) to head (1e5ced2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3277   +/-   ##
=====================================
  Coverage   80.7%   80.7%           
=====================================
  Files        129     129           
  Lines      23212   23212           
=====================================
  Hits       18750   18750           
  Misses      4462    4462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bantonsson bantonsson force-pushed the ban/remove-sampling-from-api branch from 0c873de to eac28da Compare December 3, 2025 09:19
@bantonsson bantonsson force-pushed the ban/remove-sampling-from-api branch from eac28da to 1e5ced2 Compare December 3, 2025 09:24
@bantonsson bantonsson marked this pull request as ready for review December 3, 2025 09:24
@bantonsson bantonsson requested a review from a team as a code owner December 3, 2025 09:24
@cijothomas cijothomas merged commit 759b539 into open-telemetry:main Dec 3, 2025
27 checks passed
takumi-earth pushed a commit to earthlings-dev/opentelemetry-rust that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenTelemetry API should not expose Sampling related constructs

2 participants