Skip to content

Conversation

@cijothomas
Copy link
Member

Reversing #2903
Cardinality cap is settable via Views, and Views no longer requiring opting in to experimental feature flag.

Additionally, its tricky to give a guidance to users on how to leverage Advice API to set cardinality limit, as cardinality is affected/influenced by export interval and temporality, both of which are pure SDK concerns.... Its possible that we can bring this capability back in the future with some redesign.

@cijothomas cijothomas requested a review from a team as a code owner May 22, 2025 20:34
@cijothomas cijothomas changed the title Fix: remove cardinality capping via instrument advice fix: remove cardinality capping via instrument advice May 22, 2025
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.5%. Comparing base (2018959) to head (8ded168).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2995   +/-   ##
=====================================
  Coverage   81.5%   81.5%           
=====================================
  Files        126     126           
  Lines      24796   24698   -98     
=====================================
- Hits       20209   20130   -79     
+ Misses      4587    4568   -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@utpilla utpilla merged commit 4be1a32 into open-telemetry:main May 22, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants