Skip to content

Bump MSRV to 1.70#2179

Merged
cijothomas merged 2 commits intoopen-telemetry:mainfrom
djc:msrv-1.70
Oct 7, 2024
Merged

Bump MSRV to 1.70#2179
cijothomas merged 2 commits intoopen-telemetry:mainfrom
djc:msrv-1.70

Conversation

@djc
Copy link
Contributor

@djc djc commented Oct 7, 2024

As discussed in #2168.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@djc djc requested a review from a team as a code owner October 7, 2024 11:37
@codecov
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (80771d3) to head (4f15361).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2179   +/-   ##
=====================================
  Coverage   79.0%   79.0%           
=====================================
  Files        121     121           
  Lines      20945   20945           
=====================================
+ Hits       16559   16561    +2     
+ Misses      4386    4384    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


## vNext

- Bump MSRV to 1.70 [#2179](https://github.com/open-telemetry/opentelemetry-rust/pull/2179)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be skipped as otlp is already on 1.71.1


## vNext

- Bump MSRV to 1.70 [#2179](https://github.com/open-telemetry/opentelemetry-rust/pull/2179)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please skip this, as proto is already on 1.71.1

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
(Need a minor cleanup in changelog for proto, otlp which are already on higher version)

license = "Apache-2.0"
edition = "2021"
rust-version = "1.65"
rust-version = "1.70"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - Also update the Readme.md. Not related to this PR and to be handled separately, we need to be consistent regarding mentioning or not-mentioning msrv in Readme.md for all the otel crates.

@lalitb
Copy link
Member

lalitb commented Oct 7, 2024

Thanks for the PR. LGTM with nit comments. There are few places for msrv patching and version pinning, which can be cleaned up now. I will raise a separate PR for that.

@cijothomas
Copy link
Member

Merging. The nits can be fixed as part of cleanups required in the patch scipts.

@cijothomas cijothomas merged commit 58e0904 into open-telemetry:main Oct 7, 2024
@lalitb lalitb mentioned this pull request Oct 22, 2024
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com>
takumi-earth pushed a commit to earthlings-dev/opentelemetry-rust that referenced this pull request Jan 27, 2026
Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants