Skip to content

Metrics refactor #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2020
Merged

Metrics refactor #179

merged 1 commit into from
Aug 17, 2020

Conversation

jtescher
Copy link
Member

  • Rename global::handle to global::handle_error
  • Fix race condition in env resource detector test
  • Split LockedProcessor into Checkpointer
  • Update for dimensionality reduction

@jtescher
Metrics refactor
0a2db7e 
* Rename `global::handle` to `global::handle_error`
* Fix race condition in env resource detector test
* Split `LockedProcessor` into `Checkpointer`
* Update for dimensionality reduction
@jtescher jtescher requested a review from a team August 17, 2020 02:12
MikeGoldsmith
MikeGoldsmith approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jtescher jtescher merged commit a926bfa into master Aug 17, 2020
@jtescher jtescher deleted the metrics-cleanup branch August 17, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtescher @MikeGoldsmith